Added tag extractor method and spec

This commit is contained in:
Edijs 2019-02-07 14:46:10 -07:00
parent a215f6856d
commit c0b833cb85
3 changed files with 50 additions and 17 deletions

View file

@ -0,0 +1,23 @@
export const mentionMatchesUrl = (attention, url) => {
if (url === attention.statusnet_profile_url) {
return true
}
const [namepart, instancepart] = attention.screen_name.split('@')
const matchstring = new RegExp('://' + instancepart + '/.*' + namepart + '$', 'g')
return !!url.match(matchstring)
}
/**
* Extract tag name from pleroma or mastodon url.
* i.e https://bikeshed.party/tag/photo or https://quey.org/tags/sky
* @param {string} url
*/
export const extractTagFromUrl = (url) => {
const regex = /tag[s]*\/(\w+)$/g
const result = regex.exec(url)
if (!result) {
return false
}
return result[1]
}

View file

@ -1,9 +0,0 @@
export const mentionMatchesUrl = (attention, url) => {
if (url === attention.statusnet_profile_url) {
return true
}
const [namepart, instancepart] = attention.screen_name.split('@')
const matchstring = new RegExp('://' + instancepart + '/.*' + namepart + '$', 'g')
return !!url.match(matchstring)
}

View file

@ -1,4 +1,4 @@
import * as MentionMatcher from 'src/services/mention_matcher/mention_matcher.js' import * as MatcherService from 'src/services/matcher/matcher.service.js'
const localAttn = () => ({ const localAttn = () => ({
id: 123, id: 123,
@ -16,48 +16,67 @@ const externalAttn = () => ({
statusnet_profile_url: 'https://instance.com/users/person' statusnet_profile_url: 'https://instance.com/users/person'
}) })
describe('MentionMatcher', () => { describe('MatcherService', () => {
describe.only('mentionMatchesUrl', () => { describe.only('mentionMatchesUrl', () => {
it('should match local mention', () => { it('should match local mention', () => {
const attention = localAttn() const attention = localAttn()
const url = 'https://instance.com/users/person' const url = 'https://instance.com/users/person'
expect(MentionMatcher.mentionMatchesUrl(attention, url)).to.eql(true) expect(MatcherService.mentionMatchesUrl(attention, url)).to.eql(true)
}) })
it('should not match a local mention with same name but different instance', () => { it('should not match a local mention with same name but different instance', () => {
const attention = localAttn() const attention = localAttn()
const url = 'https://website.com/users/person' const url = 'https://website.com/users/person'
expect(MentionMatcher.mentionMatchesUrl(attention, url)).to.eql(false) expect(MatcherService.mentionMatchesUrl(attention, url)).to.eql(false)
}) })
it('should match external pleroma mention', () => { it('should match external pleroma mention', () => {
const attention = externalAttn() const attention = externalAttn()
const url = 'https://instance.com/users/person' const url = 'https://instance.com/users/person'
expect(MentionMatcher.mentionMatchesUrl(attention, url)).to.eql(true) expect(MatcherService.mentionMatchesUrl(attention, url)).to.eql(true)
}) })
it('should not match external pleroma mention with same name but different instance', () => { it('should not match external pleroma mention with same name but different instance', () => {
const attention = externalAttn() const attention = externalAttn()
const url = 'https://website.com/users/person' const url = 'https://website.com/users/person'
expect(MentionMatcher.mentionMatchesUrl(attention, url)).to.eql(false) expect(MatcherService.mentionMatchesUrl(attention, url)).to.eql(false)
}) })
it('should match external mastodon mention', () => { it('should match external mastodon mention', () => {
const attention = externalAttn() const attention = externalAttn()
const url = 'https://instance.com/@person' const url = 'https://instance.com/@person'
expect(MentionMatcher.mentionMatchesUrl(attention, url)).to.eql(true) expect(MatcherService.mentionMatchesUrl(attention, url)).to.eql(true)
}) })
it('should not match external mastodon mention with same name but different instance', () => { it('should not match external mastodon mention with same name but different instance', () => {
const attention = externalAttn() const attention = externalAttn()
const url = 'https://website.com/@person' const url = 'https://website.com/@person'
expect(MentionMatcher.mentionMatchesUrl(attention, url)).to.eql(false) expect(MatcherService.mentionMatchesUrl(attention, url)).to.eql(false)
})
})
describe.only('extractTagFromUrl', () => {
it('should return tag name from valid pleroma url', () => {
const url = 'https://website.com/tag/photo'
expect(MatcherService.extractTagFromUrl(url)).to.eql('photo')
})
it('should return tag name from valid mastodon url', () => {
const url = 'https://website.com/tags/sky'
expect(MatcherService.extractTagFromUrl(url)).to.eql('sky')
})
it('should not return string but false if invalid url', () => {
const url = 'https://website.com/users/sky'
expect(MatcherService.extractTagFromUrl(url)).to.eql(false)
}) })
}) })
}) })