From fa01030641de7be89206787f5e364318086e8524 Mon Sep 17 00:00:00 2001 From: Shpuld Shpuldson Date: Thu, 3 Dec 2020 10:07:42 +0200 Subject: [PATCH] make click blocking actually work --- src/components/timeline_menu/timeline_menu.js | 8 ++++++++ src/components/timeline_menu/timeline_menu.vue | 6 ++++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/components/timeline_menu/timeline_menu.js b/src/components/timeline_menu/timeline_menu.js index ef8a5813..8d6a58b1 100644 --- a/src/components/timeline_menu/timeline_menu.js +++ b/src/components/timeline_menu/timeline_menu.js @@ -59,6 +59,14 @@ const TimelineMenu = { this.isOpen = true }, 25) }, + blockOpen (event) { + // For the blank area inside the button element. + // Just setting @click.stop="" makes unintuitive behavior when + // menu is open and clicking on the blank area doesn't close it. + if (!this.isOpen) { + event.stopPropagation() + } + }, timelineName () { const route = this.$route.name if (route === 'tag-timeline') { diff --git a/src/components/timeline_menu/timeline_menu.vue b/src/components/timeline_menu/timeline_menu.vue index dd8dbf34..3c86842b 100644 --- a/src/components/timeline_menu/timeline_menu.vue +++ b/src/components/timeline_menu/timeline_menu.vue @@ -72,7 +72,10 @@ icon="chevron-down" /> - + @@ -135,7 +138,6 @@ .click-blocker { cursor: default; - pointer-events: none; flex-grow: 1; } }